Switching to "color" input type form to change projects color #10
+64
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe "color". In addition to making the code HTML5-friendly, we also get rid of some Javascript code and a solid amount of concats in the entire codebase that add the "#" symbol to all background styles. Instead the html color is saved in the database directly with the "#" in front of it.
…rch forms. Looks better and makes the system somehow more comfortable to work with.
|
Added the "autofocus" attribute to the first fields of forms and search forms. Looks nicer and makes the system somehow more comfortable to work with. |
|
Changed the search forms from "text" to "search" type. |
|
Do we still need dotProject/modules/public/color_selector.php after this? |
|
Hmmm, looks like - no, we do not. |
|
So, are these changes going to be merged into the devel branch or rejected? Any suggestions on the commits ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Upgrading" the form for handling project colors to the HTML5 form type "color". In addition to making the code HTML5-friendly, we also get rid of some Javascript code and a solid amount of concats in the entire codebase that add the "#" symbol to all background styles. Instead the html color is saved in the database directly with the "#" in front of it.