This repository has been archived by the owner on May 23, 2024. It is now read-only.
Paging infrastructure implemented through specifications. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion added (CatalogFilterPaginatedSpecification) . EFRepository cleaned up and paging implementation added. Usage of the new paging infrastructure in CatalogService (Web and WebRazor).
|
|
|
hi, code looks good. can we include sorting here? |
- Evaluation of the specification placed in separate class.
|
Here you go, OrderBy and OrderByDescending are implemented. |
|
looks great, thanks! |
diegoszch
added a commit
to diegoszch/eShopOnWeb
that referenced
this pull request
Nov 16, 2018
Paging infrastructure implemented through specifications. (dotnet-architecture#151)
alscoundrel
pushed a commit
to alscoundrel/eShopOnWeb
that referenced
this pull request
Feb 20, 2020
…hitecture#151) * Paging criterias added in BaseSpecification. New paginated specification added (CatalogFilterPaginatedSpecification) . EFRepository cleaned up and paging implementation added. Usage of the new paging infrastructure in CatalogService (Web and WebRazor). * Use IReadOnlyList<T> instead of List<T> as return type from repositories. * - Ordering possibility added in the specification. - Evaluation of the specification placed in separate class.
alscoundrel
pushed a commit
to alscoundrel/eShopOnWeb
that referenced
this pull request
Feb 20, 2020
…hitecture#151) * Paging criterias added in BaseSpecification. New paginated specification added (CatalogFilterPaginatedSpecification) . EFRepository cleaned up and paging implementation added. Usage of the new paging infrastructure in CatalogService (Web and WebRazor). * Use IReadOnlyList<T> instead of List<T> as return type from repositories. * - Ordering possibility added in the specification. - Evaluation of the specification placed in separate class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paging criterias added in BaseSpecification.
New paginated specification added - CatalogFilterPaginatedSpecification.
EFRepository cleaned up and paging implementation added.
Usage of the new paging infrastructure in CatalogService (Web and WebRazor).