Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: EnsureDocumentStructure typo #8321

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: EnsureDocumentStructure typo #8321

merged 1 commit into from
Nov 6, 2023

Conversation

0o001
Copy link
Contributor

@0o001 0o001 commented Oct 18, 2023 •
edited by ghost
Loading

Fixes #

Main PR

Description

Customer Impact

Regression

Testing

Risk

Microsoft Reviewers: Open in CodeFlow

@0o001 0o001 requested a review from a team as a code owner October 18, 2023 09:02
@ghost ghost assigned 0o001 Oct 18, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Oct 18, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf October 18, 2023 09:02
@ghost ghost added the Community Contribution A label for all community Contributions label Oct 18, 2023
@0o001
Copy link
Contributor Author

0o001 commented Oct 18, 2023

@0o001 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

Kuldeep-MS
Kuldeep-MS approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@Kuldeep-MS Kuldeep-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

lindexi
lindexi approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@lindexi lindexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rchauhan18 rchauhan18 merged commit 17abd91 into dotnet:main Nov 6, 2023
@rchauhan18
Copy link
Contributor

Thanks @0o001 for the contribution.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kuldeep-MS Kuldeep-MS Kuldeep-MS approved these changes

@lindexi lindexi lindexi approved these changes

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees

@0o001 0o001

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0o001 @rchauhan18 @lindexi @Kuldeep-MS @dipeshmsft