Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put Unlock method within the finally block to ensure that the Lock and Unlock methods are called in pairs #8157

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Put Unlock method within the finally block to ensure that the Lock and Unlock methods are called in pairs #8157

merged 2 commits into from
Nov 6, 2023

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Aug 30, 2023 •
edited by ghost
Loading

Fixes #8134

Description

The MILUtilities.MILCopyPixelBuffer may throw ArgumentException. We put Unlock method within the finally block to ensure that the Lock and Unlock methods are called in pairs

Customer Impact

See #8134

Regression

None.

Testing

Just CI and my demo

Risk

Normal.

Microsoft Reviewers: Open in CodeFlow

@lindexi lindexi requested a review from a team as a code owner August 30, 2023 02:09
@ghost ghost assigned lindexi Aug 30, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 30, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf August 30, 2023 02:09
@ghost ghost added the Community Contribution A label for all community Contributions label Aug 30, 2023
@lindexi lindexi mentioned this pull request Aug 30, 2023
Closed
@miloush
Copy link
Contributor

miloush commented Aug 30, 2023

When does MILCopyPixelBuffer throw ArgumentException?

@lindexi
Copy link
Member Author

lindexi commented Aug 30, 2023 •
edited
Loading

When does MILCopyPixelBuffer throw ArgumentException?

@miloush See #8134

Call the WriteableBitmap WritePixels with the error stride

@miloush
Copy link
Contributor

miloush commented Aug 30, 2023

LGTM

@lindexi @miloush
Update src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/M…
b4207bb 
…edia/Imaging/WriteableBitmap.cs

Co-authored-by: Jan Kučera <10546952+miloush@users.noreply.github.com>
@ThomasGoulet73
Copy link
Contributor

LGTM

Kuldeep-MS
Kuldeep-MS approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@Kuldeep-MS Kuldeep-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@rchauhan18 rchauhan18 merged commit f9a2922 into dotnet:main Nov 6, 2023
@rchauhan18
Copy link
Contributor

Thanks @lindexi for the contribution.

@lindexi
Copy link
Member Author

lindexi commented Nov 6, 2023

Thank you @rchauhan18

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miloush miloush miloush left review comments

@Kuldeep-MS Kuldeep-MS Kuldeep-MS approved these changes

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees

@lindexi lindexi

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WPF render thread will hangs when MILUtilities.MILCopyPixelBuffer throw ArgumentException
6 participants
@lindexi @miloush @ThomasGoulet73 @rchauhan18 @Kuldeep-MS @dipeshmsft