Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullReferenceException in DynamicRenderer #7552

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Feb 20, 2023

Fixes #7537

Description

The _applicationDispatcher may be null with the thread-safe issues, see #7537

I use the argument instead of field to solve thread-safe issues.

Customer Impact

Fix #7537

Regression

None.

Testing

CI and the Demo

But I did not do enough testing.

Risk

Low

Microsoft Reviewers: Open in CodeFlow

@lindexi lindexi requested a review from a team as a code owner February 20, 2023 02:57
@ghost ghost assigned lindexi Feb 20, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Feb 20, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf February 20, 2023 02:57
@ghost ghost added the Community Contribution A label for all community Contributions label Feb 20, 2023
@singhashish-wpf
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rchauhan18
Copy link
Contributor

Thanks @lindexi for your contribution.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InkCanvas.DynamicRenderer set different custom DynamicRenderer multiple times, throw an exception
4 participants