Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/3.0.0] Update arcade to version with stable versioning support #3921

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Sep 19, 2019

No description provided.

@mmitche mmitche changed the title Update arcade to version with stable versioning support [release/3.0.0] Update arcade to version with stable versioning support Sep 19, 2019
@mmitche
Copy link
Member Author

mmitche commented Sep 19, 2019

@StephenBonikowsky This is how I have typically been stabilizing packages in 3.0:

https://github.com/dotnet/corefx/blob/release/3.0/eng/Versions.props#L11-L15

@StephenBonikowsky
Copy link
Member

@mmitche thanks for creating this pr for us.
Regarding stabilizing the packages, for previous release branches we like to do a weekly scheduled build just to make sure nothing goes stale. If we hard code StabilizePackageVersion to be true then these weekly builds would also be producing stable builds right?

How do you handle additional builds from this branch after final release in other repos?

@mmitche
Copy link
Member Author

mmitche commented Sep 19, 2019

@StephenBonikowsky They would still be stable too, which may not be desirable. Alternatively, just queue a single build with the DotNetFinalVerisonKind=true

@StephenBonikowsky StephenBonikowsky merged commit 6ce6635 into dotnet:release/3.0.0 Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants