Fix XmlSerializer to work on NetTcp/Duplex MEP #344
Conversation
|
Hi @khdang, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| dispatch.SerializeReply = _reflector.ReplyRequiresSerialization; | ||
| } | ||
|
|
||
| if (_reflector.Attribute.SupportFaults && !dispatch.IsFaultFormatterSetExplicit) |
There was a problem hiding this comment.
This is ported from Desktop code. I've removed the following because wrapper is not used at all:
else
{
var wrapper = dispatch.FaultFormatter as IDispatchFaultFormatterWrapper;
if (wrapper != null)
{
wrapper.InnerFaultFormatter = (IDispatchFaultFormatter)CreateFaultFormatter(dispatch.FaultContractInfos);
}
}
There was a problem hiding this comment.
Thanks @khdang -- just a question. What does it mean when you say "the wrapper is not used at all". Does that mean we are not currently using that code path or that it is impossible to execute that code path in NET Core?
There was a problem hiding this comment.
I mean that code path doesn't seem to have any effect since wrapper is not used anywhere else after it is initialized.
There was a problem hiding this comment.
It looks like IDispatchFaultFormatterWrapper isn't even defined in our code base. It looks like it was invented for the WebFaultFormatter in Desktop, so I think you're right it is not needed. Thanks. LGTM.
|
LGTM subject to one question in the comments above |
|
LGTM. However, prior to merge, can you fix the commit message and author? Your commit doesn't seem to be resolving to your GitHub account. |
khdang
changed the title
khdang
changed the title
khdang
force-pushed
the
fix292_xmlserializerformat
branch
from
30546cb to
5593c71
Compare
khdang
force-pushed
the
fix292_xmlserializerformat
branch
from
5593c71 to
437a48f
Compare
Fix XmlSerializer to work on NetTcp/Duplex MEP
Fix #292