Enable package signing #2755
Merged
Enable package signing #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenBonikowsky
requested review from
Lxiamail,
mconnew,
weshaggard and
zhenlan
No as long as your build definition is updated. |
weshaggard
approved these changes
Apr 11, 2018
* Missed this one change from Wes' original commit.
|
The test run succeeded in VSTS, just waiting for CI to complete. |
StephenBonikowsky
added a commit
to StephenBonikowsky/wcf
that referenced
this pull request
Apr 12, 2018
…ackageSigning Enable package signing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on dotnet/corefx#28991
@weshaggard in VSTS I will also add the "Sign Packages" step in our Publish build definition.
Are there any other changes I have missed that need to be made in order to enable signing our packages?