Update README #24
Update README #24
Conversation
|
cc: @richlander @martinwoodward @iamjasonp for feedback |
| @@ -51,7 +57,7 @@ The repo contains the following library components. | |||
|
|
|||
| ## License | |||
|
|
|||
| Windows Communication Foundation (including the wcf repo) is licensed under the [MIT license](LICENSE). | |||
| This WCF repo is licensed under the [MIT license](LICENSE). | |||
There was a problem hiding this comment.
"This project is licensed..."
|
Overall, love these changes. Some minor nits but otherwise +1 |
|
|
||
| The version of WCF in this repo runs on top of the [.NET Core](http://github.com/dotnet/core) platform, namely the [.NET Core Runtime (CoreCLR)](https://github.com/dotnet/coreclr) and [.NET Core Framework (CoreFx)](http://github.com/dotnet/corefx) | ||
| It's a subset of the .NET Framework version of Windows Communication Foundation and currently supports the same functionality available for Windows 8.1 Store apps. It is used to build .NET Core apps, including [Windows UWP](https://msdn.microsoft.com/en-us/library/windows/apps/dn609832.aspx) and [ASP.NET 5](http://weblogs.asp.net/scottgu/introducing-asp-net-5). These client libraries are suitable for mobile devices or on mid-tier servers to communicate with existing WCF services. |
There was a problem hiding this comment.
Consider "currently supports the same functionality..." -> "will support the same functionality" or "currently implements the same contract... " ?
I'm at a loss for words right now, but I want to say that we currently support the same contract as Windows Store 8.1 apps but the functionality is still work in progress.
|
👍 - really like the new updates. |
|
Consider updating dotnet-foundation/foundation#23 with "WCF Client Libraries" once we have our name at the top of the README finalized. |
|
Thanks for the suggestions. I've incorporated them in this update to the PR. |
|
|
||
| The version of WCF in this repo runs on top of the [.NET Core](http://github.com/dotnet/core) platform, namely the [.NET Core Runtime (CoreCLR)](https://github.com/dotnet/coreclr) and [.NET Core Framework (CoreFx)](http://github.com/dotnet/corefx) | ||
| It's a subset of the .NET Framework version of Windows Communication Foundation and currently supports the same API surface available for Windows 8.1 Store apps. It is used to build .NET Core apps, including [Windows UWP](https://msdn.microsoft.com/en-us/library/windows/apps/dn609832.aspx) and [ASP.NET 5](http://weblogs.asp.net/scottgu/introducing-asp-net-5). These client libraries are suitable for mobile devices or on mid-tier servers to communicate with existing WCF services. |
There was a problem hiding this comment.
👍 - "the same API surface" sounds great!
|
ACK. We are good to merge. |
No description provided.