Fixing a flaky test. #1654
Merged
Fixing a flaky test. #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
StephenBonikowsky
commented
Nov 9, 2016
StephenBonikowsky
commented
- Test case "NetTcp_TransportSecurity_Streamed_TimeOut_Long_Running_Operation" is just testing the 'SendTimeout' property on the binding, to make sure it is working as expected we only pass the test when the elapsed time falls within a narrow range.
- This test has occasionally been failing by taking longer than expected, we don't believe this is a product bug most likely caused because we were not explicitly opening the channel before starting the Stopwatch, by doing this we are remove this small but variable amount of time that was getting added to the elapsed time calculation.
* Test case "NetTcp_TransportSecurity_Streamed_TimeOut_Long_Running_Operation" is just testing the 'SendTimeout' property on the binding, to make sure it is working as expected we only pass the test when the elapsed time falls within a narrow range. * This test has occasionally been failing by taking longer than expected, we don't believe this is a product bug most likely caused because we were not explicitly opening the channel before starting the Stopwatch, by doing this we are remove this small but variable amount of time that was getting added to the elapsed time calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.