Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildtools to take fix for coverage issue. #1648

Merged
merged 1 commit into from
Nov 9, 2016

Conversation

crummel
Copy link
Contributor

@crummel crummel commented Nov 8, 2016

No description provided.

@dnfclas
Copy link

dnfclas commented Nov 8, 2016

Hi @crummel, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@crummel
Copy link
Contributor Author

crummel commented Nov 8, 2016

@roncain This should fix the coverage issue.

@roncain
Copy link
Contributor

roncain commented Nov 8, 2016

Thanks @crummel -- I'm doing a code coverage run using this patch right now to try it out.

Update: nice work @crummel -- my buddy build produced code coverage numbers I can use. I recommend we wait till CI completes, just to be sure, and then one of us can merge it.. Thanks.

Copy link
Contributor

@roncain roncain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'll check with @StephenBonikowsky about merging.

@StephenBonikowsky
Copy link
Member

Once CI passes we should be good to merge.

@StephenBonikowsky
Copy link
Member

@dotnet-bot test outerloop Ubuntu14.04

@roncain roncain merged commit c5fcd54 into dotnet:master Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants