Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine all test dependencies into one common project.json #1647

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Combine all test dependencies into one common project.json #1647

merged 1 commit into from
Nov 8, 2016

Conversation

StephenBonikowsky
Copy link
Member

  • This was done in CoreFx with PR #12345
  • Although not as impactful as for CoreFx this will shorten the time it takes to sync.
  • In addition, as a simplification improvement it makes a lot of sense.

@StephenBonikowsky
Combine all test dependencies into one common project.json
ff152a3 
* This was done in CoreFx with PR #12345
* Although not as impactful as for CoreFx this will shorten the time it takes to sync.
* In addition, as a simplification improvement it makes a lot of sense.
@StephenBonikowsky
Copy link
Member Author

@karajas when you made this change for CoreFx, was there any impact on Helix runs, do we need to update anything in any build definition or the pipe build project?

@karajas
Copy link
Member

karajas commented Nov 7, 2016 •
edited
Loading

The major fallout was the failing of of non-core test runs (uwp, ilc, desktop). These have been resolved now.

@StephenBonikowsky
Copy link
Member Author

We have ilc runs, what sort of failures did you have, what did you have to do to fix them?

@karajas
Copy link
Member

karajas commented Nov 7, 2016 •
edited
Loading

The failures were in regards to not picking up the latest version of TestSuite (925-01) which you have. I think we currently also have some issues with the ILC runner still due to some other corefx changes, @MattGal could you provide more context here?

@MattGal
Copy link
Member

MattGal commented Nov 7, 2016

Currently ILC run success is blocked by changes to System.Console which cause it to throw exceptions if color APIs are used. It does not log this nicely in runs unfortunately, but is easy to repro using the Helix repro tool.

I need to get an issue created about this, will update this thread when I do.

@karajas
Copy link
Member

karajas commented Nov 8, 2016

But this should be non-blocking to the change I believe.

@MattGal
Copy link
Member

MattGal commented Nov 8, 2016

Correct. If I get some free time I'll just fix it up myself.

@StephenBonikowsky
Copy link
Member Author

So the ilc runs will work but just get incorrectly reported?

roncain
roncain approved these changes Nov 8, 2016
View reviewed changes
Copy link
Contributor

@roncain roncain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I don't quite understand what the conversation about ILC and Helix concluded (Will it break ILC tests in Helix for WCF?) but I think we should proceed with this merge.

@StephenBonikowsky StephenBonikowsky merged commit 8c22c3f into dotnet:master Nov 8, 2016
@StephenBonikowsky StephenBonikowsky deleted the UseSingleTestProjectJson branch November 8, 2016 17:14
@StephenBonikowsky StephenBonikowsky mentioned this pull request Nov 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roncain roncain roncain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StephenBonikowsky @karajas @MattGal @roncain @dnfclas