Fix test services for addding service reference #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We would like to leverge the same test server for WCF connected service testing.
hongdai
force-pushed
the
FixWebService
branch
from
d15c946 to
12f0fab
Compare
hongdai
changed the title
|
Ready for review. |
roncain
reviewed
Oct 25, 2016
| @@ -15,7 +15,6 @@ namespace MessageContractCommon | |||
| public class MessageContractConstants | |||
| { | |||
| // CONSTANTS | |||
| public const string wrapperName = "CustomWrapperName"; | |||
There was a problem hiding this comment.
Nit: could you have just changed the constant here instead of removing it? The rest of the tests use these constants to avoid duplicating strings inside the tests. Not blocking.
There was a problem hiding this comment.
I'd prefer not to have a const defined in the common code for wrapper name as it could be different per test, although it happens to be the same for the existing 3 tests.
roncain
reviewed
Oct 25, 2016
| @@ -78,7 +76,7 @@ public interface IMessageContract | |||
|
|
|||
| public class MessageContractTypes | |||
| { | |||
| [MessageContract(IsWrapped = true, WrapperName = "CustomWrapperName", WrapperNamespace = "http://www.contoso.com")] | |||
There was a problem hiding this comment.
[No change required -- observation only] It's too bad the original test didn't use the same constants in MessageContractConstants for these attribute named parameters. It would have eliminated so much string duplication scattered in the contracts and tests.
roncain
approved these changes
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing.
bindings.