Update dev doc #1186
Merged
Update dev doc #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ``` | ||
| build.cmd /p:WithCategories=OuterLoop | ||
| ``` | ||
| To run scenario tests against an already running WCF test service, you will need to specify the base address | ||
| of the WCF test service by using the `/p:ServiceUri` parameter. This is also necessary when running | ||
| scenrio tests on Linux or OS X as the WCF service can only run on Windows. |
|
LGTM. |
| @@ -23,58 +23,61 @@ Please read [Contributing](https://github.com/dotnet/wcf/blob/master/Documentati | |||
| Building the repository | |||
| ======================= | |||
|
|
|||
| The WCF repository can be built from a regular, non-admin command prompt using build.cmd. This build produces a single System.Private.ServiceModel assembly that implements the individual client libraries. | |||
| The WCF repository can be built from a regular, non-admin command prompt using build.cmd on Windows or build.sh on *nix. | |||
There was a problem hiding this comment.
NIT: consider using "non-Windows" or "other" platforms, not sure if people would associate OS X as "*nix"
There was a problem hiding this comment.
Agreed. Updated to "other platforms".
|
LGTM - no blocking comments, though it'd be good to have the spelling typos corrected at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new instructions of outerloop testing
Also updated dev doc to include build.sh for x-plat.
fixes #1166
skip ci please