Remove certificate matching by name #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ConditionalFact detector for certificates was using a fallback strategy to locate certificates based on IssuedBy and SubjectName when it could not locate by thumbprint. But this allowed matches on left-over certificates that would not work. With this change, we match only on thumbprint or report that there is no certificate installed and let the ConditionalFact skip the certificate tests. Fixes dotnet#1172
|
@dotnet-bot test all outerloop please |
|
Reviewers: the OuterLoop failures are the known NetHttps test failures we consciously chose to allow for a short time. Console output reveals they did, in fact, succeed in installing the root and client certs. |
|
Wondering if we're actually better off trying to ensure that the leftovers are cleaned up properly... I'm trying to recall why we chose to match by name previously instead of matching by thumbprint (and i think it was for historical reasons where we didn't know in advance what the thumbprint for a cert was going to be) Changes LGTM |
|
*nix OuterLoop failures are the known NetHttps tests we are consciously allowing to fail in CI for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConditionalFact detector for certificates was using a fallback
strategy to locate certificates based on IssuedBy and SubjectName
when it could not locate by thumbprint. But this allowed matches
on left-over certificates that would not work.
With this change, we match only on thumbprint or report that there
is no certificate installed and let the ConditionalFact skip the
certificate tests.
Fixes #1172