Add scenario test for channel extensibility model #1171

khdang · 2016-05-17T00:49:24Z

I've ported the Custom Message Interceptor but it seems that the channel extensibility model doesn't work yet.

khdang · 2016-05-17T05:16:03Z

@dotnet-bot test outerloop Windows_NT
@dotnet-bot test outerloop selfhost Windows_NT

roncain · 2016-05-17T12:10:58Z

@khdang could you rebase and try again? All the Outerloop tests failed in unexpected ways. The selfhost failure has a compile error, meaning you are probably also failing to build under IIS.

roncain · 2016-05-17T13:09:27Z

If you try to build tools\SelfHostedWcfService\SelfHostedWcfService.sln you will see many compile errors. This explains why all OuterLoops fail because neither self-host nor IIS-host can build the server side code.

After rebasing and resolving the merge conflicts reported, please do 'build /p:WithCategories=OuterLoop' to verify the code runs before updating the PR

In reply to: 219699069 [](ancestors = 219699069)

roncain · 2016-05-17T13:10:54Z

src/System.Private.ServiceModel/tools/SelfHostedWcfService/ChannelExtensibilityService.cs

+using System.ServiceModel;
+using System.ServiceModel.Channels;
+
+namespace WcfService


This file is in the wrong place. All server-side .cs files live under the IISHostedWcfService\App_code folder and are included by the self-host project. Was there some reason you could not put this in IISHostedWcfService?

This was not intentional I'll move this to IISHostedWcfService\App_code folder

roncain · 2016-05-17T13:28:47Z

I think the tests really belong in a new folder under Scenarios/Extensibility. This is all about the extensibility at the channel layer and less about testing CustomBinding.
@StephenBonikowsky -- thoughts on correct placement?

StephenBonikowsky · 2016-05-17T17:21:19Z

Yes I agree, this test is meant to replace the old test we had that was based on the Mahjong game to test the MessageInspector scenario.
I think you should place it under Scenarios/Extensibility in a new "MessageInspector" directory.

Also, there are a lot of extra files needed for the test, I would recommend putting the test itself in a MessageInspectorTests.cs and all the other files under another subdirectory called "TestData", I plan on going back and making this same kind of change in other test folders, this way it is easy to differentiate files containing the tests and any other supporting files.

You will need to add a new *.csproj and add it to the solution.

StephenBonikowsky · 2016-05-17T17:25:03Z

src/System.Private.ServiceModel/tests/Scenarios/Binding/Custom/CustomBindingTests.cs

@@ -51,4 +51,69 @@ public static void DefaultSettings_Tcp_Binary_Echo_RoundTrips_String()
            ScenarioTestHelpers.CloseCommunicationObjects((ICommunicationObject)serviceProxy, factory);
        }
    }
+
+    public class MessageModifier : ChannelMessageInterceptor
+    {


Test files should only contain test methods, could you move this to a separate file or into one of the other test support files you already have.

I have a task to clean this up in other areas of our test bed.

Thanks Ron and Stephen! That makes sense. Let me move this new test to Scenarios/Extensibility

khdang · 2016-05-17T22:55:22Z

@dotnet-bot test outerloop Windows_NT
@dotnet-bot test outerloop selfhost Windows_NT

roncain · 2016-05-17T23:21:47Z

...ate.ServiceModel/tests/Scenarios/Extensibility/MessageInterceptor/MessageInterceptorTests.cs

+
+    [Fact]
+    [OuterLoop]
+    [ActiveIssue(1170)]


It would be good to understand why this test fails before we disable it. @khdang , can this test be changed to pass, or do we understand the failure enough to know it is a product issue?

roncain · 2016-05-18T00:10:56Z

@dotnet-bot test outerloop Windows_NT
@dotnet-bot test outerloop selfhost Windows_NT

roncain · 2016-05-18T15:49:19Z

@khdang -- would you please ping this PR when it is ready to review? It still fails to build, which is why you get a 100% failure rate in OuterLoops. You can see this by building SelfHostedWcfService.sln. These same errors will occur when IIS attempts to build the contents of its virtual directory, meaning no WCF services are available.

Build FAILED.

"c:\OSS\wcf\src\System.Private.ServiceModel\tools\SelfHostedWcfService\SelfHostedWCFService.sln" (default target) (1) ->
"c:\OSS\wcf\src\System.Private.ServiceModel\tools\SelfHostedWcfService\SelfHostedWCFService.csproj" (default target) (2) ->
(CoreCompile target) -> 
  c:\OSS\wcf\src\System.Private.ServiceModel\tools\IISHostedWcfService\App_code\AsyncResult.cs(121,17): error CS0103: The name 'callback' does not exist in the current context [c:\OSS\wcf\src\System.Private.ServiceModel\tools\SelfHostedWcfService\SelfHostedWCFService.csproj]
  c:\OSS\wcf\src\System.Private.ServiceModel\tools\IISHostedWcfService\App_code\AsyncResult.cs(150,29): error CS1061: 'TAsyncResult' does not contain a definition for 'endCalled' and no extension method 'endCalled' accepting a first argument of type 'TAsyncResult' could be found (are you missing a using directive or an assembly reference?) [c:\OSS\wcf\src\System.Private.ServiceModel\tools\SelfHostedWcfService\SelfHostedWCFService.csproj]
  c:\OSS\wcf\src\System.Private.ServiceModel\tools\IISHostedWcfService\App_code\AsyncResult.cs(155,25): error CS1061: 'TAsyncResult' does not contain a definition for 'endCalled' and no extension method 'endCalled' accepting a first argument of type 'TAsyncResult' could be found (are you missing a using directive or an assembly reference?) [c:\OSS\wcf\src\System.Private.ServiceModel\tools\SelfHostedWcfService\SelfHostedWCFService.csproj]
  c:\OSS\wcf\src\System.Private.ServiceModel\tools\IISHostedWcfService\App_code\AsyncResult.cs(157,30): error CS1061: 'TAsyncResult' does not contain a definition for 'isCompleted' and no extension method 'isCompleted' accepting a first argument of type 'TAsyncResult' could be found (are you missing a using directive or an assembly reference?) [c:\OSS\wcf\src\System.Private.ServiceModel\tools\SelfHostedWcfService\SelfHostedWCFService.csproj]
  c:\OSS\wcf\src\System.Private.ServiceModel\tools\IISHostedWcfService\App_code\AsyncResult.cs(162,29): error CS1061: 'TAsyncResult' does not contain a definition for 'manualResetEvent' and no extension method 'manualResetEvent' accepting a first argument of type 'TAsyncResult' could be found (are you missing a using directive or an assembly reference?) [c:\OSS\wcf\src\System.Private.ServiceModel\tools\SelfHostedWcfService\SelfHostedWCFService.csproj]
  c:\OSS\wcf\src\System.Private.ServiceModel\tools\IISHostedWcfService\App_code\AsyncResult.cs(164,29): error CS1061: 'TAsyncResult' does not contain a definition for 'manualResetEvent' and no extension method 'manualResetEvent' accepting a first argument of type 'TAsyncResult' could be found (are you missing a using directive or an assembly reference?) [c:\OSS\wcf\src\System.Private.ServiceModel\tools\SelfHostedWcfService\SelfHostedWCFService.csproj]
  c:\OSS\wcf\src\System.Private.ServiceModel\tools\IISHostedWcfService\App_code\AsyncResult.cs(167,29): error CS1061: 'TAsyncResult' does not contain a definition for 'exception' and no extension method 'exception' accepting a first argument of type 'TAsyncResult' could be found (are you missing a using directive or an assembly reference?) [c:\OSS\wcf\src\System.Private.ServiceModel\tools\SelfHostedWcfService\SelfHostedWCFService.csproj]
  c:\OSS\wcf\src\System.Private.ServiceModel\tools\IISHostedWcfService\App_code\AsyncResult.cs(169,35): error CS1061: 'TAsyncResult' does not contain a definition for 'exception' and no extension method 'exception' accepting a first argument of type 'TAsyncResult' could be found (are you missing a using directive or an assembly reference?) [c:\OSS\wcf\src\System.Private.ServiceModel\tools\SelfHostedWcfService\SelfHostedWCFService.csproj]

    0 Warning(s)
    8 Error(s)

khdang · 2016-05-18T16:43:46Z

Initially I run StartWCFSelfHostedService.cmd and it went pass the "Building WCF Self hosted sevice.." step without error so I thought there is no issues with the build. But I did notice the errors in your previous comments. Let me resolve that.

khdang · 2016-05-19T20:51:37Z

@dotnet-bot test outerloop Windows_NT
@dotnet-bot test outerloop selfhost Windows_NT

khdang · 2016-05-19T20:55:48Z

I've fixed the errors when building SelfHostedWCFService. It's a bug in CodeFormatter that it doesn't rename all the occurrences of variables.

I've fixed the tests issue as well by opening channels properly. I think this should verify that the channel extensibility model works.

As for #623 2nd task, the LayeredChannel doesn't seem to be covered with this test so that need to be done separately.

khdang · 2016-05-19T21:07:56Z

It looks like I need to update the test service for the new tests.

Starting:    Extensibility.MessageInterceptor.Tests
14:04:14      MessageInterceptorTests.CustomBinding_Message_Interceptor [FAIL]
14:04:14         System.ServiceModel.EndpointNotFoundException : There was no endpoint listening at http://wcfcoresrv2.cloudapp.net/WcfService15//ChannelExtensibility.svc//ChannelExtensibility that could accept the message. This is often caused by an incorrect address or SOAP action. See InnerException, if present, for more details.
14:04:14         Stack Trace:

roncain · 2016-05-19T21:19:21Z

src/System.Private.ServiceModel/tools/SelfHostedWcfService/SelfHostedWCFService.csproj

@@ -39,6 +39,7 @@
      <Private>True</Private>
    </Reference>
    <Reference Include="System" />
+    <Reference Include="System.configuration" />


Nit: System.Configuration (upper-case 'C")

roncain · 2016-05-19T21:32:44Z

LGTM subject to a couple things:

Get CI to pass Windows OuterLoops by updating the web.config as mentioned in a comment
Once that passes, ask to run all outerloops (look at other PR's that contain "test all outerloop " -- I don't want to make trigger it by accident 😀)
Consider renaming the one file to match the casing of the class name

Once we get an CI OuterLoop pass for all OSes, I'm fine merging this.

khdang · 2016-05-20T00:07:51Z

@dotnet-bot test outerloop Windows_NT
@dotnet-bot test outerloop selfhost Windows_NT

khdang · 2016-05-20T00:25:53Z

@dotnet-bot test all outerloop please

khdang · 2016-05-20T00:46:13Z

@dotnet-bot test OuterLoop Selfhost Windows_NT Release
@dotnet-bot test OuterLoop Ubuntu14.04 Debug
@dotnet-bot test OuterLoop Ubuntu14.04 Release

roncain · 2016-05-20T13:02:41Z

@khdang -- I think the Ubuntu and OSX OuterLoop failures are unrelated to your PR, and you should go ahead and merge.
Looking at the failures, it looks like the PRService is encountering problems attempting to initialize the build tools. If I sync my Ubuntu VM to your PR and run exactly the same build script that PRService attempted (found in the console log for the failure in the Details link), I actually see the new MessageInspector test run and pass. I think we need to investigate the PR machine separately to discover why it failed to init the build tools -- but don't block this PR on that.

/cc: @iamjasonp

khdang · 2016-05-20T16:51:29Z

Thanks @roncain! I will squash the commits and merge.

khdang · 2016-05-20T16:59:50Z

@dotnet-bot test all outerloop please

iamjasonp · 2016-05-20T18:18:02Z

ACK - issues look transient to me

roncain · 2016-05-20T19:53:57Z

LGTM. I recommend checking in asap @khdang -- today is the last day before we branch.
The one failing test is not related to this PR. I think it is a flakey test and I will fix that separately.

dnfclas added the cla-already-signed label May 17, 2016

leecow added the 2 - In Progress label May 17, 2016

roncain reviewed May 17, 2016
View reviewed changes

StephenBonikowsky reviewed May 17, 2016
View reviewed changes

khdang force-pushed the add_scenario_tests_extensiblity_model branch 2 times, most recently from a96dc07 to 083bea4 Compare May 17, 2016 22:54

khdang force-pushed the add_scenario_tests_extensiblity_model branch from 083bea4 to 42f84cf Compare May 17, 2016 22:58

roncain reviewed May 17, 2016
View reviewed changes

roncain reviewed May 19, 2016
View reviewed changes

Add scenario test for channel extensibility model

bbaeb92

khdang force-pushed the add_scenario_tests_extensiblity_model branch from ab0b94e to bbaeb92 Compare May 20, 2016 16:52

khdang merged commit 45dbfc2 into dotnet:master May 20, 2016

khdang deleted the add_scenario_tests_extensiblity_model branch May 20, 2016 20:21

leecow removed the 2 - In Progress label May 20, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add scenario test for channel extensibility model #1171

Add scenario test for channel extensibility model #1171

khdang commented May 17, 2016 •

edited

Loading

khdang commented May 17, 2016

roncain commented May 17, 2016

roncain commented May 17, 2016

roncain May 17, 2016

khdang May 17, 2016

roncain commented May 17, 2016

StephenBonikowsky commented May 17, 2016

StephenBonikowsky May 17, 2016

khdang May 17, 2016

khdang commented May 17, 2016

roncain May 17, 2016

roncain commented May 18, 2016

roncain commented May 18, 2016

khdang commented May 18, 2016

khdang commented May 19, 2016

khdang commented May 19, 2016 •

edited

Loading

khdang commented May 19, 2016

roncain May 19, 2016

roncain commented May 19, 2016

khdang commented May 20, 2016

khdang commented May 20, 2016

khdang commented May 20, 2016

roncain commented May 20, 2016

khdang commented May 20, 2016

khdang commented May 20, 2016

iamjasonp commented May 20, 2016

roncain commented May 20, 2016

Add scenario test for channel extensibility model #1171

Add scenario test for channel extensibility model #1171

Conversation

khdang commented May 17, 2016 • edited Loading

khdang commented May 17, 2016

roncain commented May 17, 2016

roncain commented May 17, 2016

roncain May 17, 2016

Choose a reason for hiding this comment

khdang May 17, 2016

Choose a reason for hiding this comment

roncain commented May 17, 2016

StephenBonikowsky commented May 17, 2016

StephenBonikowsky May 17, 2016

Choose a reason for hiding this comment

khdang May 17, 2016

Choose a reason for hiding this comment

khdang commented May 17, 2016

roncain May 17, 2016

Choose a reason for hiding this comment

roncain commented May 18, 2016

roncain commented May 18, 2016

khdang commented May 18, 2016

khdang commented May 19, 2016

khdang commented May 19, 2016 • edited Loading

khdang commented May 19, 2016

roncain May 19, 2016

Choose a reason for hiding this comment

roncain commented May 19, 2016

khdang commented May 20, 2016

khdang commented May 20, 2016

khdang commented May 20, 2016

roncain commented May 20, 2016

khdang commented May 20, 2016

khdang commented May 20, 2016

iamjasonp commented May 20, 2016

roncain commented May 20, 2016

khdang commented May 17, 2016 •

edited

Loading

khdang commented May 19, 2016 •

edited

Loading