Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NetHttpsBinding test coverage. #1160

Merged
merged 1 commit into from
May 17, 2016
Merged

Add NetHttpsBinding test coverage. #1160

merged 1 commit into from
May 17, 2016
+346 −1

Conversation

StephenBonikowsky
Copy link
Member

@StephenBonikowsky
Copy link
Member Author

Clearly something isn't happy 😀

roncain
roncain reviewed May 16, 2016
View reviewed changes
...em.Private.ServiceModel/tests/Scenarios/Client/ChannelLayer/DuplexChannelShapeTests.4.0.0.cs
@@ -12,7 +12,7 @@
using System.Xml;
using Xunit;

public static class DuplexChannelShapeTests
public static partial class DuplexChannelShapeTests
Copy link
Contributor

@roncain roncain May 16, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add " : ConditionalWcfTest" to this line to make it derive from the base class containing the ConditionalFact conditions. I know you already did that in the other partial class for this, but the partial type declarations should match.

@StephenBonikowsky
Add NetHttpsBinding test coverage.
f641d96 
* Adding tests for NetHttpsBinding.
* Fixes dotnet#507
@StephenBonikowsky StephenBonikowsky force-pushed the AddNetHttpsBindingTests branch from 3ad8f65 to f641d96 Compare May 16, 2016 22:03
@StephenBonikowsky
Copy link
Member Author

Updated

@StephenBonikowsky
Copy link
Member Author

@dotnet-bot test all outerloop please

@roncain
Copy link
Contributor

roncain commented May 17, 2016

Note: looking at the Console output for the Ubuntu failures, we apparently succeeded in installing the certs:

Using root cert in store by thumbprint '41571D814ABFE7669F757C9253F2695D1E024FF9' = '[Subject]
    CN=DO_NOT_TRUST_WcfBridgeRootCA, O=DO_NOT_TRUST, OU=Created by https://github.com/dotnet/wcf

  [Issuer]
    CN=DO_NOT_TRUST_WcfBridgeRootCA, O=DO_NOT_TRUST, OU=Created by https://github.com/dotnet/wcf

  [Serial Number]
    0082DD601AF83DA77F

  [Not Before]
    5/2/16 4:58:11 PM

  [Not After]
    6/1/16 5:58:11 PM

  [Thumbprint]
    41571D814ABFE7669F757C9253F2695D1E024FF9
  '
  Using client cert in store by thumbprint 'C14A4D88D4F596A2ABFE3A416A79EDF5C54C99E7' = '[Subject]
    CN=WCF Client Certificate, O=DO_NOT_TRUST, OU=Created by https://github.com/dotnet/wcf

  [Issuer]
    CN=DO_NOT_TRUST_WcfBridgeRootCA, O=DO_NOT_TRUST, OU=Created by https://github.com/dotnet/wcf

  [Serial Number]
    18DBB351782B6DA7

  [Not Before]
    5/2/16 4:58:11 PM

  [Not After]
    6/1/16 5:58:11 PM

  [Thumbprint]
    C14A4D88D4F596A2ABFE3A416A79EDF5C54C99E7

But then the tests fail with:

     Binding_Http_NetHttpsBindingTests.NonDefaultCtor_NetHttps_Echo_RoundTrips_String [FAIL]
        System.ServiceModel.CommunicationException : An error occurred while sending the request.
        ---- System.Net.Http.HttpRequestException : An error occurred while sending the request.
        -------- System.Net.Http.CurlException : SSL peer certificate or SSH remote key was not OK

These look like the same reason for failure as listed in #1123. We may want to ActiveIssue these tests with #1123 as we did those other tests.

@StephenBonikowsky
Copy link
Member Author

I think you are right, will update with that ActiveIssue.

@roncain
Copy link
Contributor

roncain commented May 17, 2016

Be aware #1129 has asked to not use ActiveIssue(1123) for those other tests but condition with ConditionalFact. But because we haven't decided what that ConditionalFact would test for, I don't see any option but to ActiveIssue these tests with 1123 and know we need to come back and ConditionalFact them later.

@StephenBonikowsky
Copy link
Member Author

StephenBonikowsky commented May 17, 2016 •
edited
Loading

After discussing this further, going to merge and we will treat these tests just like the other ones in terms of how to get them working or skipped on Linux runs. In the meantime they add coverage on Windows.

@StephenBonikowsky StephenBonikowsky merged commit 0277b0f into dotnet:master May 17, 2016
@roncain
Copy link
Contributor

roncain commented May 17, 2016

LGTM
As we discussed, I'll see if an improved ConditionalFact allows these to be skipped.

@StephenBonikowsky StephenBonikowsky deleted the AddNetHttpsBindingTests branch July 25, 2016 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StephenBonikowsky @roncain @leecow @dnfclas