Enable tests following the net10 transition #44931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abling tests that were previously disabled for that.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
@dotnet/sdk-container-builds-maintainers this is reenabling all container tests that were disabled during the net10 transition. A bunch are still failing but only on the linux leg. What needs to be done for these? Should they be marked as windows only for now? |
|
Looking into this |
…does some stuff with packages that I couldn't find way around. The fix is not nice, but we need at least some tests for now, before we can return to a proper state - e.g. when the container images for net10.0 are ready.
|
@dotnet/sdk-container-builds-maintainers can someone review the changes to the container tests and then I can merge? |
Forgind
reviewed
Nov 26, 2024
test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs
Outdated
Show resolved
Hide resolved
surayya-MS
requested changes
Nov 27, 2024
test/Microsoft.NET.Build.Containers.IntegrationTests/CreateNewImageTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs
Outdated
Show resolved
Hide resolved
surayya-MS
approved these changes
Nov 27, 2024
|
@marcpopMSFT the PR is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all of the .NET 10 planned authoring is done, let's try reenabling tests that were previously disabled for that. More changes may be required but starting with just trying to run them as is.