Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to 17.8.3 for the minimum msbuild version #43995

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

marcpopMSFT
Copy link
Member

@marcpopMSFT marcpopMSFT commented Oct 8, 2024

Summary
For context here, NuGet got a package alert and so updated their MSBuild version which forced us to update ours here: https://github.com/dotnet/sdk/pull/40997/files

zivkan fixed that in nuget with 6.11.1 so we can switch this back.

We should be able to revert this back and match our documentation

Nuget 6.11.1 switched back to depending on 17.8 so we should be able to revert this back
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Oct 8, 2024
@marcpopMSFT
Copy link
Member Author

For context here, NuGet got a package alert and so updated their MSBuild version which forced us to update ours here: https://github.com/dotnet/sdk/pull/40997/files

zivkan fixed that in nuget with 6.11.1 so we can switch this back.

@jaredpar
Copy link
Member

What impact does this end up having? I'm unsure where this gets used.

@marcpopMSFT
Copy link
Member Author

What impact does this end up having? I'm unsure where this gets used.

@jaredpar this means that you can load 8.0.4xx in 17.8 (whereas currently it won't load in that version).

@marcpopMSFT marcpopMSFT merged commit a662254 into release/8.0.4xx Oct 14, 2024
17 checks passed
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-switchbacktominversion branch October 14, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants