[main] Update dependencies from dotnet/windowsdesktop #42742

dotnet-maestro · 2024-08-14T22:42:42Z

This pull request updates the following dependencies

From https://github.com/dotnet/windowsdesktop

Subscription: 43b77b68-0b3c-49dd-3915-08d8e9750bf8
Build: 20240820.1
Date Produced: August 20, 2024 8:11:47 AM UTC
Commit: 973ef0220d9c46ce427fb983e4aad805c72cabad
Branch: refs/heads/main

Updates:
- Microsoft.WindowsDesktop.App.Ref: from 10.0.0-alpha.1.24415.4 to 10.0.0-alpha.1.24420.1
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 10.0.0-alpha.1.24415.4 to 10.0.0-alpha.1.24420.1
- VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0: from 10.0.0-alpha.1.24415.4 to 10.0.0-alpha.1.24420.1
- VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0: from 10.0.0-alpha.1.24415.4 to 10.0.0-alpha.1.24420.1

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.NET.Sdk.WindowsDesktop: from 10.0.0-alpha.1.24415.1 to 10.0.0-alpha.1.24415.2 (parent: Microsoft.WindowsDesktop.App.Ref)
- Microsoft.Dotnet.WinForms.ProjectTemplates: from 9.0.0-rc.1.24407.3 to 10.0.0-alpha.1.24414.12 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
- Microsoft.DotNet.Wpf.ProjectTemplates: from 10.0.0-alpha.1.24415.1 to 10.0.0-alpha.1.24415.2 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)

…ld 20240814.4 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 From Version 9.0.0-rc.1.24414.1 -> To Version 10.0.0-alpha.1.24414.4

dotnet-maestro · 2024-08-14T22:52:51Z

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

…ld 20240814.6 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 From Version 10.0.0-alpha.1.24414.4 -> To Version 10.0.0-alpha.1.24414.6 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop,Microsoft.DotNet.Wpf.ProjectTemplates From Version 9.0.0-rc.1.24413.3 -> To Version 10.0.0-alpha.1.24414.7 (parent: Microsoft.WindowsDesktop.App.Ref

…ld 20240815.2 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 From Version 10.0.0-alpha.1.24414.6 -> To Version 10.0.0-alpha.1.24415.2 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop,Microsoft.DotNet.Wpf.ProjectTemplates From Version 10.0.0-alpha.1.24414.7 -> To Version 10.0.0-alpha.1.24415.1 (parent: Microsoft.WindowsDesktop.App.Ref

…ld 20240815.3 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 From Version 10.0.0-alpha.1.24415.2 -> To Version 10.0.0-alpha.1.24415.3

Forgind · 2024-08-15T16:18:39Z

D:\a\_work\1\s\src\Installer\redist-installer\targets\GenerateLayout.targets(411,5): error : Download from all targets failed. List of attempted targets: https://dotnetcli.blob.core.windows.net/dotnet/WindowsDesktop/9.0.0-rc.1.24414.1/windowsdesktop-runtime-10.0.0-alpha.1.24415.3-win-x64.zip, https://dotnetbuilds.blob.core.windows.net/public/WindowsDesktop/9.0.0-rc.1.24414.1/windowsdesktop-runtime-10.0.0-alpha.1.24415.3-win-x64.zip [D:\a\_work\1\s\src\Installer\redist-installer\redist-installer.csproj]
##[error]src\Installer\redist-installer\targets\GenerateLayout.targets(411,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Download from all targets failed. List of attempted targets: https://dotnetcli.blob.core.windows.net/dotnet/WindowsDesktop/9.0.0-rc.1.24414.1/windowsdesktop-runtime-10.0.0-alpha.1.24415.3-win-x64.zip, https://dotnetbuilds.blob.core.windows.net/public/WindowsDesktop/9.0.0-rc.1.24414.1/windowsdesktop-runtime-10.0.0-alpha.1.24415.3-win-x64.zip
D:\a\_work\1\s\src\Installer\redist-installer\targets\GenerateLayout.targets(411,5): error : Failed to download file using addresses in Uri and/or Uris. [D:\a\_work\1\s\src\Installer\redist-installer\redist-installer.csproj]
##[error]src\Installer\redist-installer\targets\GenerateLayout.targets(411,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Failed to download file using addresses in Uri and/or Uris.

This looks like some windows desktop-related files are unavailable? @dotnet/dotnet-windowsdesktop-admin

…ld 20240815.4 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 From Version 10.0.0-alpha.1.24415.3 -> To Version 10.0.0-alpha.1.24415.4 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates From Version 10.0.0-alpha.1.24415.1 -> To Version 10.0.0-alpha.1.24415.2 (parent: Microsoft.WindowsDesktop.App.Ref

mthalman · 2024-08-15T17:02:22Z

This PR is needed to unblock #42742.

…5cec1f5-e512-45be-9aa3-eeb62a1f50a1

ViktorHofer · 2024-08-19T15:56:06Z

The windows failure is a real one. This path is too long:

D:\a_work\1\vmr\src\windowsdesktop\artifacts\obj\Microsoft.WindowsDesktop.App.Ref\Release\win-x64\output\packs\Microsoft.WindowsDesktop.App.Ref\10.0.0-alpha.1.24415.4\analyzers\dotnet\vb\pt-BR\System.Windows.Forms.Analyzers.CodeFixes.VisualBasic.resources.dll

261 chars.

cc @KlausLoeffelmann

ViktorHofer · 2024-08-19T15:58:11Z

@jkoritzinsky this error is showing up again and again. Until we get native tools that can avoid the MAX_PATH limitation, would it be possible to reduce the shared framework package output path length?

More precisely, this part: obj\Microsoft.WindowsDesktop.App.Ref\Release\win-x64\output\packs\Microsoft.WindowsDesktop.App.Ref\

Do we need all this: output\packs\Microsoft.WindowsDesktop.App.Ref\?

Note that we already avoid the TFM in the output path for the same reason: https://github.com/dotnet/windowsdesktop/blob/2628d1ae1ec1e0ce22751e0bf83294141708c3e9/src/windowsdesktop/src/sfx/Microsoft.WindowsDesktop.App.Ref.sfxproj#L11

jkoritzinsky · 2024-08-19T16:50:30Z

We need packs/Microsoft.WindowsDesktop.App.Ref as we need to package up the layout of what we're putting on disk. We can shorten output, but to do anything else we'd need to change how we build the installers to have less of the path on disk (have them install into the packs/Microsoft.WindowsDesktop.App.Ref path instead of installing into the .NET install root path).

ViktorHofer · 2024-08-19T17:07:27Z

We could change the sfx project's BaseIntermediateOutputPath and IntermediateOutputPath to something shorter, right? I.e. refpack and runtimepack.

jkoritzinsky · 2024-08-19T17:08:53Z

Yes, we can do that as well

Helps with dotnet/sdk#42742 by reducing the output paths lengths for windowsdesktop packs to a minimum. Also add a build.sh file and set the right chmod permissions for it to be able to build this repo on Unix (i.e. codespace).

ViktorHofer · 2024-08-20T07:49:52Z

@jkoritzinsky shortening the output paths worked: dotnet/windowsdesktop#4585

Helps with dotnet/sdk#42742 by reducing the output paths lengths for windowsdesktop packs to a minimum. Also add a build.sh file and set the right chmod permissions for it to be able to build this repo on Unix (i.e. codespace).

…ld 20240820.1 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.10.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.10.0 From Version 10.0.0-alpha.1.24415.4 -> To Version 10.0.0-alpha.1.24420.1

akoeplinger · 2024-08-20T10:01:48Z

/azp run sdk-unified-build,sdk-source-build

azure-pipelines · 2024-08-20T10:01:58Z

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

akoeplinger · 2024-08-20T11:03:56Z

/azp run sdk-unified-build,sdk-source-build

azure-pipelines · 2024-08-20T11:04:11Z

Azure Pipelines successfully started running 2 pipeline(s).

Update dependencies from https://github.com/dotnet/windowsdesktop bui…

7add1e0

…ld 20240814.4 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 From Version 9.0.0-rc.1.24414.1 -> To Version 10.0.0-alpha.1.24414.4

dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Aug 14, 2024

dotnet-maestro bot added 3 commits August 15, 2024 02:48

Update dependencies from https://github.com/dotnet/windowsdesktop bui…

a000ce0

…ld 20240815.3 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 From Version 10.0.0-alpha.1.24415.2 -> To Version 10.0.0-alpha.1.24415.3

mthalman added 2 commits August 15, 2024 14:09

Merge branch 'main' into darc-main-c5cec1f5-e512-45be-9aa3-eeb62a1f50a1

6239e30

Delete obsolete wpf patch

5e980db

mthalman requested review from a team as code owners August 15, 2024 19:34

Merge branch 'main' of https://github.com/dotnet/sdk into darc-main-c…

266dfa6

…5cec1f5-e512-45be-9aa3-eeb62a1f50a1

lewing added Area-CodeFlow and removed Area-Infrastructure labels Aug 19, 2024

lewing approved these changes Aug 19, 2024

View reviewed changes

Add dotnet10 feeds

89c51dd

ViktorHofer approved these changes Aug 19, 2024

View reviewed changes

ViktorHofer enabled auto-merge (squash) August 19, 2024 13:25

ViktorHofer added 6 commits August 19, 2024 16:07

Update Version.Details.xml

afebb9e

Update Versions.props

c4c3190

Update Versions.props

2f8c3c6

Update GenerateLayout.targets

559cadc

Update Versions.props

cc9afd9

Update GenerateLayout.targets

9139cc9

jkoritzinsky mentioned this pull request Aug 19, 2024

Shorten output path for wix install layout dotnet/arcade#15008

Merged

ViktorHofer mentioned this pull request Aug 20, 2024

Shorten windowsdesktop output paths dotnet/windowsdesktop#4585

Merged

ViktorHofer merged commit da8c470 into main Aug 20, 2024
40 of 41 checks passed

ViktorHofer deleted the darc-main-c5cec1f5-e512-45be-9aa3-eeb62a1f50a1 branch August 20, 2024 13:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/windowsdesktop #42742

[main] Update dependencies from dotnet/windowsdesktop #42742

dotnet-maestro bot commented Aug 14, 2024 •

edited

Loading

dotnet-maestro bot commented Aug 14, 2024

Forgind commented Aug 15, 2024

mthalman commented Aug 15, 2024

ViktorHofer commented Aug 19, 2024

ViktorHofer commented Aug 19, 2024 •

edited

Loading

jkoritzinsky commented Aug 19, 2024

ViktorHofer commented Aug 19, 2024

jkoritzinsky commented Aug 19, 2024

ViktorHofer commented Aug 20, 2024

akoeplinger commented Aug 20, 2024

azure-pipelines bot commented Aug 20, 2024

akoeplinger commented Aug 20, 2024

azure-pipelines bot commented Aug 20, 2024

[main] Update dependencies from dotnet/windowsdesktop #42742

[main] Update dependencies from dotnet/windowsdesktop #42742

Conversation

dotnet-maestro bot commented Aug 14, 2024 • edited Loading

From https://github.com/dotnet/windowsdesktop

Coherency Updates

dotnet-maestro bot commented Aug 14, 2024

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

Forgind commented Aug 15, 2024

mthalman commented Aug 15, 2024

ViktorHofer commented Aug 19, 2024

ViktorHofer commented Aug 19, 2024 • edited Loading

jkoritzinsky commented Aug 19, 2024

ViktorHofer commented Aug 19, 2024

jkoritzinsky commented Aug 19, 2024

ViktorHofer commented Aug 20, 2024

akoeplinger commented Aug 20, 2024

azure-pipelines bot commented Aug 20, 2024

akoeplinger commented Aug 20, 2024

azure-pipelines bot commented Aug 20, 2024

dotnet-maestro bot commented Aug 14, 2024 •

edited

Loading

ViktorHofer commented Aug 19, 2024 •

edited

Loading