Show workload update notifications for workloads installed via Visual Studio #40705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Workloads
untriaged
joeloff
reviewed
May 6, 2024
|
|
||
| string existingVersionToOverwrite = result.StdOut; | ||
|
|
||
| var installedSdkFolder = $@"c:\Program Files\dotnet\sdk\{existingVersionToOverwrite}"; |
There was a problem hiding this comment.
This path is only safe if someone is using an x64 SDK, so this won't work if you ever ran this under x64 emulation on arm64.
There was a problem hiding this comment.
This is for the VM-based tests, which aren't currently targeting various architectures.
joeloff
reviewed
May 6, 2024
joeloff
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40295
Also adds some more workload tests and the ability for VM tests to have different start states.