Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move compatibility tools into common folder #35964

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Move compatibility tools into common folder #35964

merged 3 commits into from
Oct 10, 2023

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Oct 10, 2023 •
edited
Loading

Three commits:

  1. Move compatibility tools (APICompat & GenAPI) together into a common "Compatibility" folder. This allows to define common properties more easily and avoids references across the repository.
  2. Update the paths in build files and solution files because of the move.
  3. Small TFM fixes and updates

@ViktorHofer ViktorHofer self-assigned this Oct 10, 2023
@ViktorHofer ViktorHofer requested review from andriipatsula and a team as code owners October 10, 2023 12:44
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Oct 10, 2023
ericstj
ericstj approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will make it easier to work on these tools.

@ViktorHofer ViktorHofer merged commit 1543690 into main Oct 10, 2023
@ViktorHofer ViktorHofer deleted the MoveCompatibilityToolsIntoCommonFolder branch October 10, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericstj ericstj ericstj approved these changes

@andriipatsula andriipatsula Awaiting requested review from andriipatsula

Assignees

@ViktorHofer ViktorHofer

Labels
Area-ApiCompat Area-GenAPI untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorHofer @ericstj