Adding support for additional auth scenarios for Zip Deploy #31999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-WebSDK
untriaged
| @@ -11,9 +11,12 @@ namespace Microsoft.NET.Sdk.Publish.Tasks.ZipDeploy | |||
| { | |||
| internal static class HttpClientHelpers | |||
| { | |||
| public static async Task<IHttpResponse> PostWithBasicAuthAsync(this IHttpClient client, Uri uri, string username, string password, string contentType, string userAgent, Encoding encoding, Stream messageBody) | |||
| internal static readonly string AzureADUserName = Guid.Empty.ToString(); | |||
There was a problem hiding this comment.
I don't see anything in .NET SDK providing "00000000-0000-0000-0000-000000000000" as the user name to ZipDeploy. Is it hardcoded in Visual Studio, instead?
| @@ -93,7 +93,7 @@ public async System.Threading.Tasks.Task<bool> ZipDeployAsync(string zipToPublis | |||
| Uri uri = new Uri($"{zipDeployPublishUrl}?isAsync=true", UriKind.Absolute); | |||
| string userAgent = $"{UserAgentName}/{userAgentVersion}"; | |||
There was a problem hiding this comment.
userAgentVersion here seems to come from Microsoft.NET.Sdk.Publish.ZipDeploy.targets
sdk/src/WebSdk/Publish/Tasks/Tasks/ZipDeploy/ZipDeploy.cs
Lines 15 to 21 in a603f14
so the whole User-Agent can then be "websdk/WebSdk", which seems a bit redundant.
marcpopMSFT
added a commit
that referenced
this pull request
May 4, 2023
marcpopMSFT
added a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.