Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the minimum VS version #31720

Merged
merged 6 commits into from
Apr 26, 2023
Merged

Conversation

marcpopMSFT
Copy link
Member

There have been issues with 8.0 running against 17.5

There have been issues with 8.0 running against 17.5
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 11, 2023
@marcpopMSFT
Copy link
Member Author

Looks like I can't update this until 17.6 releases. I'll update the installer UI at least.

@marcpopMSFT
Copy link
Member Author

@rainersigwald looks like you added the read of the minimummsbuildversion file in SDK. Looks like I can't update the minimum version until after the version releases from now on. Is that about right? I think I'm ok with that but just thought I'd confirm that. https://github.com/dotnet/sdk/blob/main/eng/Versions.props#L109

@rainersigwald
Copy link
Member

I don't think that aspect of it was intentional. I think you could add the prerelease feed to unblock yourself for now:

<add key="darc-pub-DotNet-msbuild-Trusted-8ffc3fe" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-DotNet-msbuild-Trusted-8ffc3fe3/nuget/v3/index.json" />

@marcpopMSFT
Copy link
Member Author

@rainersigwald build still failed. Did I get the right feed?

@marcpopMSFT
Copy link
Member Author

@rainersigwald per your comment, overriding the build value with 17.6.1 which comes from the feed. This forced a few additional changes that I'll want to run by Daniel.

eng/Versions.props Show resolved Hide resolved
@marcpopMSFT marcpopMSFT enabled auto-merge April 25, 2023 21:32
…mework and we wouldn't find out till it was in VS if this weren't working.
@marcpopMSFT marcpopMSFT merged commit c7ff098 into main Apr 26, 2023
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-updateminimummsbuild branch April 26, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants