-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the minimum VS version #31720
Conversation
There have been issues with 8.0 running against 17.5
Looks like I can't update this until 17.6 releases. I'll update the installer UI at least. |
@rainersigwald looks like you added the read of the minimummsbuildversion file in SDK. Looks like I can't update the minimum version until after the version releases from now on. Is that about right? I think I'm ok with that but just thought I'd confirm that. https://github.com/dotnet/sdk/blob/main/eng/Versions.props#L109 |
I don't think that aspect of it was intentional. I think you could add the prerelease feed to unblock yourself for now: Line 9 in f9b1191
|
@rainersigwald build still failed. Did I get the right feed? |
This forced an update to the config interop assembly and then collections immutable.
@rainersigwald per your comment, overriding the build value with 17.6.1 which comes from the feed. This forced a few additional changes that I'll want to run by Daniel. |
…mework and we wouldn't find out till it was in VS if this weren't working.
There have been issues with 8.0 running against 17.5