Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vb item templates #29765

Merged
merged 11 commits into from
Jan 12, 2023
Merged

add vb item templates #29765

merged 11 commits into from
Jan 12, 2023

Conversation

YuliiaKovalova
Copy link
Member

Add Visual Basic item templates:

  • Class
  • Structure
  • Interface
  • Enum

and cover them with Integration tests

@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner January 5, 2023 13:37
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@YuliiaKovalova YuliiaKovalova marked this pull request as draft January 6, 2023 20:47
@YuliiaKovalova YuliiaKovalova marked this pull request as ready for review January 12, 2023 10:42
@JanKrivanek JanKrivanek added the Area-Common templates Covers templates in the repo (classlib, console, common item templates) label Jan 12, 2023
JanKrivanek
JanKrivanek approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

baronfel
baronfel approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, but I had a question about some commented-out tests.

src/Tests/dotnet-new.Tests/DotnetClassTemplateTests.cs Outdated Show resolved Hide resolved
src/Tests/dotnet-new.Tests/DotnetClassTemplateTests.cs Outdated Show resolved Hide resolved
@YuliiaKovalova YuliiaKovalova merged commit bbc0390 into dotnet:release/7.0.2xx Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

@JanKrivanek JanKrivanek JanKrivanek approved these changes

Assignees
No one assigned
Labels
Area-Common templates Covers templates in the repo (classlib, console, common item templates)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuliiaKovalova @baronfel @JanKrivanek