Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.1xx] Inverted language version conditions in console / classlib templates to support new language features for newer language versions #29636

Conversation

YuliiaKovalova
Copy link
Member

Problem

fixes dotnet/templating#5668

Description

In the fix the condition on language version was reverted, so the default behavior is new syntax and that the C#11 and further language versions will use new syntax.

Customer Impact

After the fix, the template that utilizes the latest language features (top-level statements, file-scoped namespaces etc) will be used.

Testing

Automated

Risk

Very low
Those conditions are already used in .NET 8 templates and passing the tests

Checks:

Added unit tests - existing tests cover the change
Added #nullable enable to all the modified files ? - NA

@YuliiaKovalova YuliiaKovalova changed the title [DO NOT MERGE] [release/7.0.1xx] Inverted language version conditions in console / classlib templates to support new language features for newer language versions [release/7.0.1xx] Inverted language version conditions in console / classlib templates to support new language features for newer language versions Jan 5, 2023
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@YuliiaKovalova YuliiaKovalova merged commit aebfb39 into dotnet:release/7.0.1xx Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants