Rework SnakeCase/KebabCase naming policies to closer match Json.NET's #90316
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsAs an alternative to #90248, this PR reworks the naming policies so that non-alphanumeric characters are never being trimmed or replaced, while still making sure that this Json.NET bug is addressed. Fix #77309.
|
eiriktsarpalis
requested review from
JamesNK,
jeffhandley,
stephentoub,
layomia and
tarekgh
|
I just left comments on #90248. What's the difference between this one and that? |
|
I like it much more than the previous attempt, and it fits into the survey results which isn't representative at the moment. There are two votes on Mastodon for keeping punctuation, but another one from Twitter is for trimming. With the first question things are much better and there are 86% of votes for partial compatibility with JSON.NET on Mastodon and 50% on Twitter (where just two people voted). |
The difference is in how punctuation is treated: #90248 (comment). This pull request behaves more naturally. |
eiriktsarpalis
changed the title
|
@YohDeadfall thank you for providing useful feedback! |
This PR:
After a lot of discussion we concluded that:
JsonNamingPolicy.CamelCase. We should consider adding surrogate pair support in the future, although that would require addressing Proposal: Create OOB package for Rune, System.Text.Unicode.Utf8, and related APIs #52947.Fix #77309.