Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dotnetbuilds domain #110939

Closed
wants to merge 1 commit into from
Closed

Update dotnetbuilds domain #110939

wants to merge 1 commit into from

Conversation

richlander
Copy link
Member

Related: dotnet/core#9671

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@richlander
Copy link
Member Author

Oh ... Is this file updated via Arcade/Maestro?

@am11
Copy link
Member

am11 commented Dec 25, 2024

Oh ... Is this file updated via Arcade/Maestro?

Yes, https://github.com/dotnet/runtime/blob/main/eng/common/README.md.
Optionally we can keep this PR to test the CI and even merge it afterwards while the change from arcade is being propagated. Key is to avoid arcade sync revert the change subsequently.

jkoritzinsky
jkoritzinsky approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates need to also be ported to dotnet/arcade or they'll be overwritten on the next Arcade update.

This was referenced Dec 25, 2024
Open
Open
@richlander richlander closed this Dec 25, 2024
@richlander
Copy link
Member Author

richlander commented Dec 25, 2024 •
edited
Loading

Merging one of these PRs will have much of the same effect, due to the change in the same files:

https://github.com/dotnet/runtime/pull/110907/files#diff-72b8f8e899b94872c6ead31fd06ec109da15bcb9ad2af6e78103d6763a31c637R267

It would be valuable to get some usage on the new script. The script at the official location will change shortly.

@mmitche @baronfel

@ViktorHofer ViktorHofer deleted the azureedgedotnet branch December 25, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@richlander richlander

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richlander @am11 @jkoritzinsky