Ensure a null PublicKey is supported on assembly refs #108907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Oct 15, 2024
jkoritzinsky
added a commit
to jkoritzinsky/DNMD
that referenced
this pull request
Oct 15, 2024
jkotas
approved these changes
Oct 15, 2024
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11366596971 |
4 tasks
jkoritzinsky
added a commit
to AaronRobinsonMSFT/DNMD
that referenced
this pull request
Oct 16, 2024
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Oct 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108517.
Regression from #95536 which was done early in v9. If the referenced assembly had no private key, the uninitialized
StrongNameTokenvariable was used as the PublicKey which would contain random values instead of the expectednull.This should be ported to v9.