Allow the client to update the server logging level dynamically #75615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
dibarbet
commented
Oct 25, 2024
| builder.SetMinimumLevel(serverConfiguration.MinimumLogLevel); | ||
| // The actual logger is responsible for deciding whether to log based on the current log level. | ||
| // The factory should be configured to log everything. | ||
| builder.SetMinimumLevel(LogLevel.Trace); |
There was a problem hiding this comment.
As best as I can tell it is not possible to change this level after creation. So we have to check the log level in the logger itself.
dibarbet
force-pushed
the
dynamic_log_level
branch
from
939e71a to
56374f2
Compare
JoeRobich
approved these changes
Oct 25, 2024
src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Logging/LspLogMessageLogger.cs
Outdated
Show resolved
Hide resolved
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client side change - dotnet/vscode-csharp#7688
Allows us to update the log level dynamically as the server is running.