Fix issue causing prepare tests to pass when it actually failed #69353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to discover tests in a single assembly
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
sharwell
approved these changes
Aug 3, 2023
RikkiGibson
approved these changes
Aug 3, 2023
RikkiGibson
approved these changes
Aug 3, 2023
jasonmalinowski
approved these changes
Aug 3, 2023
|
|
|
@RikkiGibson can you override merge? I know the integration tests are going to fail - #69364 |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c91e128 fixes an issue where prepare tests would pass when it actually failed. From a bit of logging I verified that the RunWorker was successfully returning a failure response, but due to read+write in the parallel for it was being lost and incorrectly returning success. For a CI example, see this run - https://dev.azure.com/dnceng-public/public/_build/results?buildId=360938&view=logs&j=86868256-cb82-53ae-480d-0cc498d0e893&t=5266d39a-6887-515c-9441-254dc333cb9c
e7e8871 fixes discovery by upgrade the test discovery worker to .net8