Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename interceptors feature flag #68430

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Rename interceptors feature flag #68430

merged 2 commits into from
Jun 5, 2023

Conversation

RikkiGibson
Copy link
Contributor

@RikkiGibson RikkiGibson commented Jun 2, 2023 •
edited by jcouv
Loading

See discussion in dotnet/sdk#32950

Relates to test plan #67421

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 2, 2023
@RikkiGibson RikkiGibson marked this pull request as ready for review June 5, 2023 17:13
@RikkiGibson RikkiGibson requested a review from a team as a code owner June 5, 2023 17:13
jcouv
jcouv approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv jcouv self-assigned this Jun 5, 2023
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 5, 2023
@jcouv jcouv added this to the 17.7 milestone Jun 5, 2023
@RikkiGibson RikkiGibson requested a review from a team June 5, 2023 18:50
@RikkiGibson RikkiGibson merged commit 234000b into dotnet:features/interceptors Jun 5, 2023
@RikkiGibson RikkiGibson deleted the rename-feature-flag branch June 5, 2023 19:40
@allisonchou allisonchou mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@cston cston cston approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
17.7
Development

Successfully merging this pull request may close these issues.
3 participants
@RikkiGibson @cston @jcouv