Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Consistently use Keyword helper in C# help service #68015

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Refactoring: Consistently use Keyword helper in C# help service #68015

merged 1 commit into from
Apr 28, 2023

Conversation

jhinder
Copy link
Contributor

@jhinder jhinder commented Apr 28, 2023

Some of the keyword help texts were string literals, some were generated with the Keyword helper method. Now they are unified to consistently use the helper method.

@jhinder jhinder requested a review from a team as a code owner April 28, 2023 10:27
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 28, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 28, 2023
@jhinder
Copy link
Contributor Author

jhinder commented Apr 28, 2023

@CyrusNajmabadi Could you please merge this PR? All checks are green.

@genlu genlu merged commit e3f89a4 into dotnet:main Apr 28, 2023
@ghost ghost added this to the Next milestone Apr 28, 2023
@genlu
Copy link
Member

genlu commented Apr 28, 2023

Thanks! @jhinder

@jhinder jhinder deleted the helpservice-keyword-refactor branch April 29, 2023 16:01
@allisonchou allisonchou mentioned this pull request May 2, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.7 P2
Development

Successfully merging this pull request may close these issues.
4 participants
@jhinder @genlu @CyrusNajmabadi @Cosifne