Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CompletionResolve tests #67983

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix CompletionResolve tests #67983

merged 1 commit into from
Apr 26, 2023

Conversation

genlu
Copy link
Member

@genlu genlu commented Apr 26, 2023

We were modifying the input item directly when creating the expected result

@genlu genlu requested a review from a team as a code owner April 26, 2023 17:30
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 26, 2023
@genlu genlu requested a review from dibarbet April 26, 2023 17:30
@genlu genlu merged commit 2d50318 into dotnet:main Apr 26, 2023
@ghost ghost added this to the Next milestone Apr 26, 2023
@genlu genlu deleted the fixtest branch April 27, 2023 23:10
@allisonchou allisonchou mentioned this pull request May 2, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.7 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@genlu @dibarbet @Cosifne