Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental Generators documentation fixes #67593

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Incremental Generators documentation fixes #67593

merged 4 commits into from
Apr 26, 2023

Conversation

davecluderay
Copy link
Contributor

This is really clear, precise and helpful documentation.
I noticed a few small things as I was going through it, hence this PR.
Three separate commits that should be self-explanatory.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 31, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 31, 2023
jjonescz
jjonescz approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@jjonescz jjonescz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jjonescz jjonescz merged commit 2531dd2 into dotnet:main Apr 26, 2023
@ghost ghost added this to the Next milestone Apr 26, 2023
@allisonchou allisonchou mentioned this pull request May 2, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjonescz jjonescz jjonescz approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Documentation Feature - Source Generators Source Generators untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.7 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@davecluderay @jjonescz @Cosifne