Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osx rid to coreclr projs #6250

Merged
merged 3 commits into from
Oct 22, 2015
Merged

Conversation

agocke
Copy link
Member

@agocke agocke commented Oct 22, 2015

This sets us up to do coreclr bootstrapping on OS X as well.

@dotnet/roslyn-compiler @jasonmalinowski @davkean Please review

/cc @davidfowl

@@ -11,7 +11,7 @@
"lib/net45/BasicUndo.dll": {}
}
},
"Microsoft.CodeAnalysis.Test.Resources.Proprietary/1.1.0-beta1-20150824-02": {
"Microsoft.CodeAnalysis.Test.Resources.Proprietary/1.2.0-beta-20151016-11": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed this file by mistake, but this does need to be changed.

@jasonmalinowski
Copy link
Member

👍. I assume that the osx.10.10 RID is something the packages already know about and you've confirmed that's what to use by somebody.

@agocke
Copy link
Member Author

agocke commented Oct 22, 2015

@jasonmalinowski Correct.

@Pilchie
Copy link
Member

Pilchie commented Oct 22, 2015

👍

agocke added a commit that referenced this pull request Oct 22, 2015
@agocke agocke merged commit 8105295 into dotnet:master Oct 22, 2015
@agocke agocke deleted the AddOsxRidToCoreclrProjs branch October 22, 2015 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants