Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug6215 #6223

Merged
merged 4 commits into from
Oct 22, 2015
Merged

Bug6215 #6223

merged 4 commits into from
Oct 22, 2015

Conversation

mattwar
Copy link
Contributor

@mattwar mattwar commented Oct 21, 2015

Fix for #6215 API Review followup

Note: only made changed to MSBuildProjectLoader.LoadProjectAsync because argument to LoadSolutionAsync wasn't being used, so I removed it.

@Pilchie @DustinCampbell please review

@Pilchie
Copy link
Member

Pilchie commented Oct 21, 2015

👍

@davkean
Copy link
Member

davkean commented Oct 21, 2015

Your builds were aborted when Jenkins went down, reran them.

@davkean
Copy link
Member

davkean commented Oct 22, 2015

👍

mattwar added a commit that referenced this pull request Oct 22, 2015
@mattwar
Merge pull request #6223 from mattwar/Bug6215
d922169 
Bug6215
@mattwar mattwar merged commit d922169 into dotnet:master Oct 22, 2015
@Pilchie Pilchie mentioned this pull request Oct 28, 2015
Merged
@mattwar mattwar deleted the Bug6215 branch August 29, 2016 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattwar @Pilchie @davkean @dnfclas