-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master into privateProtected #22047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs and minor optimizations (e.g. StringBuilder from pool)
…is in a common base class). * Added glyph to completion item * Added type info test for InternalsVisibleToAttribute (SemanticModel) including test * Added support for three out of four ways to strong name an assembly: * By csproj property *AssemblyOriginatorKeyFile* (was already supported) * By compiler option (was already supported) * By *AssemblyKeyFileAttribute* and *AssemblyKeyNameAttribute* (new, requires compilation of every assembly). Test case added. * Not supported: By Assembly Linker (IMO not possible) * Added test for delayed signing
…in the appropriate places (found a weird edge case). * Changed semantic check and removed check of the attribute name (and added test for type alias) * Code cleanup as reviewed
…s. Some more minor changes.
…letion list (because syntaxFactsService.IsElementAccessExpression is called in GetAttributeSyntaxNodeOfToken)
…already "InternalsVisibleTo" by looking up of InternalsVisibleTo attribute instances of the current project.
…fic syntax trees directly instead by visitor pattern.
…n the wrong document
…lsVisibleToAttribute method
* Full Windows PDB determinism * Update DSRN to 1.7.0-private-25621 * Avoid caching zero chunks * PR feedback
* Use DSRN version 1.7.0-beta-25631 * Fill in missing document entries in PDB tests * Update pdb to xml converter to 1.1.0-beta1-62106-02
added more diagnostic info on OOP code.
- Fixed variable typo in all files I could find it in
InternalsVisibleToCompletionProvider
fixing merge break: adding document attribute to pdb in broken tests
Avoid AggregateException in TaskExtensions.WaitAndGetResult
… full actual result. (dotnet#21336)
21898 - Fixed typo in help message
The testing instructure for CoreCLR currently runs all assemblies in parallel in a single process, so resources, which are static and lazy initialized, must have thread synchronization. Otherwise, tests which depend on object or symbol identity could fail if they retrieve different copies of the same resource. Fixes dotnet#21937
Fix issue with merging parameters
…r-20170908-070011 Merge dev15.4.x to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.