Fix up .gitattributes to clone .sh files with LF #22036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(apparently if you forget to add reviewers/labels, then try to add them in quickly, and have the label editor open while dnfclas does its thing, the web UI sets labels to the old state (when you initially opened the editor) when you confirm adding the label - so |
sharwell
approved these changes
Sep 11, 2017
jasonmalinowski
approved these changes
Sep 11, 2017
jasonmalinowski
requested changes
Sep 11, 2017
.gitattributes
Outdated
| @@ -10,8 +10,7 @@ | |||
| # | |||
| # However, right now the toolset packages must be built on Windows, and so the | |||
| # files must be hard-coded to be cloned with LF | |||
| src/Compilers/CSharp/CscCore/csc text eol=lf | |||
| src/Compilers/VisualBasic/VbcCore/vbc text eol=lf | |||
| *.sh text eol=lf | |||
There was a problem hiding this comment.
The comment is no longer matching the code now. Can we update accordingly?
|
@jasonmalinowski Updated the comment |
jasonmalinowski
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also,
src/Compilers/CSharp/CscCore/csc(and vbc) no longer exist.This is particularly annoying when using WSL with
git config core.eol crlf, as that fixes a lot of issues with native windows git interacting with WSL git, but we should still check out all of our helper scripts with LF, so they can still be ran in WSL. (If they have CRLF line endings, everything gets really upset)