Updating some nuspec to list the correct framework requirements and dependencies. #21991
Conversation
|
FYI. @jaredpar, @agocke, @jasonmalinowski, @jmarolf, @dotnet/roslyn-infrastructure |
|
Also FYI. @tmat |
| private static IEnumerable<ISetupInstance> EnumerateVisualStudioInstances() | ||
| { | ||
| var setupConfiguration = GetSetupConfiguration() as ISetupConfiguration2; | ||
| var setupConfiguration new SetupConfiguration(); |
There was a problem hiding this comment.
If this compiles, please file a compiler bug. :-)
|
Tagging @khyperia as well |
| @@ -17,7 +17,7 @@ | |||
| <projectUrl>$projectUrl$</projectUrl> | |||
| <tags>$tags$</tags> | |||
| <dependencies> | |||
| <group targetFramework="NETCoreApp1.0"> | |||
| <group targetFramework="netcoreapp1.1"> | |||
There was a problem hiding this comment.
What verificatioin do we have that thius is correct?
There was a problem hiding this comment.
Manual right now. I went and checked each assembly/file included in the package (and its dependent packages).
CsiCore is currently targeting netcoreapp1.1: https://github.com/dotnet/roslyn/blob/master/src/Interactive/CsiCore/CsiCore.csproj#L13
And for the other package, CscCore and VbcCore are currently targeting netcoreapp2.0: https://github.com/dotnet/roslyn/blob/master/src/Compilers/CSharp/CscCore/CscCore.csproj#L15 and https://github.com/dotnet/roslyn/blob/master/src/Compilers/VisualBasic/VbcCore/VbcCore.csproj#L15
There was a problem hiding this comment.
I also validated the deps.json and the runtimeconfig.json in the latest signed build output for these projects
|
@jaredpar, any other feedback, or am I good to merge (pending the VSI test passing)? |
|
fine to merge but we should have some item tracking verifying these |
This fixes up
Microsoft.Net.CSharp.Interactive.netcore.nuspecandMicrosoft.Net.Compilers.netcore.nuspecto list the actual target framework: nc1.1 and nc2.0, respectively. These are the target frameworks of tools they include (csicore targets nc1.1 and csccore targets nc2.0).This also updates
Microsoft.VisualStudio.IntegrationTest.Utilities.nuspecto list a missing dependency (System.Diagnostics.Process) and to move to the new version ofMicrosoft.VisualStudio.Setup.Configuration.Interop. Additionally, theMicrosoft.VisualStudio.Setup.Configuration.Native.x86dependency was dropped as they are no longer producing a native DLL.