Wpf startup #2389
Merged
Wpf startup #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoopedBard3
requested changes
Apr 21, 2022
There was a problem hiding this comment.
It looks like the runs have returned invalid values for the WPF startup value:
Metric |Average |Min |Max
[2022/04/21 00:04:23][INFO] ---------------|---------------|---------------|---------------
[2022/04/21 00:04:23][INFO] WPF Startup |-125.702 ms |-125.702 ms |-125.702 ms
[2022/04/21 00:04:23][INFO] Time on Thread |323.438 ms |323.438 ms |323.438 ms
I am assuming the startup time should not be negative? The test also only ran once, we should test with more. Looking at the code nothing obvious pops out as to why the time is negative but something is going wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds WPF startup capabilities to the performance lab. We also add two tests: