[XC] SetValue on nullable BP types #26387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
previously approved these changes
Dec 5, 2024
jfversluis
previously approved these changes
Dec 5, 2024
StephaneDelcroix
force-pushed
the
fix_26369
branch
from
546e8f3 to
63e2713
Compare
StephaneDelcroix
commented
Dec 5, 2024
| { | ||
| MockCompiler.Compile(typeof(Maui26369), out var methodDef, out var hasLoggedErrors); | ||
| Assert.IsFalse(hasLoggedErrors); | ||
| Assert.False(ContainsBoxToNullable(methodDef)); |
There was a problem hiding this comment.
this tests that the faulty IL isn't present anymore
| } | ||
|
|
||
| var page = new Maui26369(useCompiledXaml); | ||
| Assert.That(page.NullableGridLength, Is.EqualTo(new GridLength(30))); |
There was a problem hiding this comment.
and this tests that the IL is valid and behave as expected (this was failing before as well)
PureWeen
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
SetValue on nullable BP types. generate like the compiler would
Issues Fixed