Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FlyoutBehavior on Basic Template #26352

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Dec 4, 2024

Description of Change

There's no reason to set the FlyoutBehavior on the basic template

FlyoutBehavior should typically just be inferred from the Shell structure and then the user can modify it for different scenarios.

@PureWeen PureWeen requested a review from a team as a code owner December 4, 2024 04:11
@jfversluis
Copy link
Member

Actually it was set to Disabled before on the basic (non-sample content) template, see: 0883291#diff-b4606caa426a8339283bdc3c964b81e543e985648531e50cf6e3e304c49523b7R7

It seems that maybe got lost while adding the sample content to this. Should we reinstate that?

@rmarinho rmarinho merged commit a57ab5d into main Dec 4, 2024
20 checks passed
@rmarinho rmarinho deleted the PureWeen/remove_flyout_behavior_template branch December 4, 2024 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants