Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix deselect item on CollectionView #26315

Merged
merged 9 commits into from
Dec 6, 2024
Merged

[iOS] Fix deselect item on CollectionView #26315

merged 9 commits into from
Dec 6, 2024

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Dec 2, 2024

Description of Change

We fixed the selection with "CollectionView SelectedItem binding on iOS" #25555 , but seems that introduced a regression where clearing the item was not working.

BY calling the clear state also with. PerformBatchUpdates after the layout is done seems to fix the issue.

Issues Fixed

Fixes #26187

@rmarinho rmarinho added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Dec 2, 2024
@rmarinho rmarinho added this to the .NET 9 SR2 milestone Dec 2, 2024
@rmarinho rmarinho requested a review from a team as a code owner December 2, 2024 18:23
@rmarinho rmarinho requested review from Eilon and PureWeen December 2, 2024 18:23
@rmarinho rmarinho requested a review from PureWeen December 5, 2024 01:27
@PureWeen
Copy link
Member

PureWeen commented Dec 6, 2024

  • failing lanes are unrelated to these changes

@PureWeen PureWeen merged commit 66982c3 into main Dec 6, 2024
101 of 104 checks passed
@PureWeen PureWeen deleted the fix-26187 branch December 6, 2024 21:33
@samhouts samhouts added fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[MAUI] Select items traces are preserved
4 participants