Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GraphicsView UiTestCategory #26307

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add GraphicsView UiTestCategory #26307

merged 1 commit into from
Dec 3, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Dec 2, 2024 •
edited
Loading

I'd like to fix a few GraphicsView issues, but I've noticed that there's no UiTestCategory for this Control.

For example #26304

@jfversluis can this category by added? :)

@kubaflo kubaflo requested a review from a team as a code owner December 2, 2024 15:04
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 2, 2024
@kubaflo kubaflo added area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing area-testing Unit tests, device tests and removed community ✨ Community Contribution labels Dec 2, 2024
@kubaflo kubaflo mentioned this pull request Dec 2, 2024
Open
@kubaflo kubaflo requested a review from jfversluis December 2, 2024 15:06
@jfversluis
Copy link
Member

Seems good to me, thanks! Currently, we're having some issues with running the UI Test stuff, as soon as we clear that I'll trigger CI and get this through!

@kubaflo kubaflo mentioned this pull request Dec 3, 2024
Open
@jfversluis
Copy link
Member

jfversluis commented Dec 3, 2024 •
edited
Loading

/azp run

@github-actions github-actions bot force-pushed the graphics-view-ui-test-category branch from 885b093 to 9613645 Compare December 3, 2024 07:40
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis merged commit 076160b into dotnet:main Dec 3, 2024
102 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfversluis jfversluis jfversluis approved these changes

@Eilon Eilon Awaiting requested review from Eilon Eilon is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing area-testing Unit tests, device tests fixed-in-9.0.21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubaflo @jfversluis @samhouts