Fixed the double tap editor freeze issue and added test cases #26203
+66
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 28, 2024
| @@ -61,16 +61,16 @@ public override Size GetDesiredSize(double widthConstraint, double heightConstra | |||
| // get an exception; it doesn't know what do to with it. So instead we'll size | |||
| // it to fit its current contents and use those values to replace infinite constraints | |||
|
|
|||
| PlatformView.SizeToFit(); | |||
| var sizeThatFits = PlatformView.SizeThatFits(new CGSize(widthConstraint, heightConstraint)); | |||
There was a problem hiding this comment.
Exactly the same logic is applied in the SearchBar, happens the same problem? does it require the same changes?
If need the same changes, could you add a test covering the fix in the SearchBar?
There was a problem hiding this comment.
@jsuarezruiz, Since the issue arises when AutoSize is set in the editor, and AutoSize is not supported in the search bar, the search bar does not exhibit the freezing behavior and functions as expected.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Dec 4, 2024
sheiksyedm
added
the
partner/syncfusion
samhouts
added
fixed-in-9.0.21
fixed-in-net8.0-nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
Double-tapping the editor causes the app to freeze or become unresponsive.
Root Cause
When you double-tap the editor and AutoSize is set to "TextChanges," the editor continuously resizes to fit the content, leading to the app freezing or hanging.
Description of Change
Issues Fixed
Fixes #25975
Fixes #25940
Fixes #25938
Fixes #17757
Tested the behaviour in the following platforms
Output Screenshot
BeforeFix.mp4
AfterFix.mp4