Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code that enables/disables Entry #26101

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Remove code that enables/disables Entry #26101

merged 2 commits into from
Nov 26, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Nov 25, 2024

Description of Change

I ran the test added to the original PR #24064 with the code removed and it still passes from what you can see on this issue. So, I'm just going to revert this change for now because we don't have any reason to keep this change and it's a fairly negative result that it can cause an auto scroll in some scenarios.

I've added a test, so when/if we add this code back in.

Issues Fixed

Fixes #25829

@PureWeen PureWeen marked this pull request as ready for review November 25, 2024 21:10
@PureWeen PureWeen requested a review from a team as a code owner November 25, 2024 21:10
@PureWeen
Copy link
Member Author

/backport to release/9.0.1xx

Copy link
Contributor

Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/12019064268

@PureWeen
Copy link
Member Author

/backport to release/9.0.1xx-sr1

Copy link
Contributor

Started backporting to release/9.0.1xx-sr1: https://github.com/dotnet/maui/actions/runs/12019139110

@PureWeen PureWeen merged commit a743c25 into main Nov 26, 2024
104 checks passed
@PureWeen PureWeen deleted the fix_25829 branch November 26, 2024 00:30
@samhouts samhouts added fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[9.0 GA, Android] ScrollView starts at the position of first Entry control on the bottom rather than at 0
3 participants