[XC] fix compiled bindings containing arrays #25949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't get the property on the array type but on the element type - fixes #25819
| @@ -1005,12 +1010,12 @@ static IEnumerable<Instruction> CompiledBindingGetHandlers(TypeReference tSource | |||
| il.Emit(Ldarga_S, (byte)0); | |||
| else | |||
| il.Emit(Ldarg_0); | |||
| var lastGetterTypeRef = properties[i - 1].property.PropertyType; | |||
| var lastGetterTypeRef = properties[i - 1].property?.PropertyType; | |||
There was a problem hiding this comment.
this and the next change are preventing the NRE reported as the issue
| @@ -666,7 +666,12 @@ static bool TryParsePath(ILContext context, string path, TypeReference tSourceRe | |||
| previousPartTypeRef = indexer.PropertyType.ResolveGenericParameters(indexerDeclTypeRef); | |||
| } | |||
| else | |||
| { | |||
| if (previousPartTypeRef.IsArray) | |||
There was a problem hiding this comment.
this makes it produce valid, executable, and correct code
mattleibow
approved these changes
Nov 20, 2024
jsuarezruiz
approved these changes
Nov 20, 2024
both are needed. the reported exception was a NRE, and the code should go through that null ref to end up on the actual fix. This is all strange, as this used to work, but the capability was somehow broken at some point, and we didn't had test for that part |
samhouts
added
fixed-in-9.0.21
fixed-in-net8.0-nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
don't get the property on the array type but on the element type
Issues Fixed