Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] update AOT profile for .NET 9 GA #25509

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[android] update AOT profile for .NET 9 GA #25509

merged 1 commit into from
Oct 25, 2024

Conversation

jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Oct 24, 2024 •
edited by PureWeen
Loading

There are very few changes as this point, but recording a new profile shows a few changes, and maybe improvement by a very small amount:

Before:
Average(ms): 450.1
Std Err(ms): 3.53537676760043
Std Dev(ms): 11.1798429724611
After:
Average(ms): 448.6
Std Err(ms): 2.54383787044519
Std Dev(ms): 8.04432166879912

This is an average of 10 runs on a dotnet new maui template on a Pixel 7 Pro.

It might be effectively the same, but it's worth updating I suppose.

Fixes #25403

@jonathanpeppers
[android] update AOT profile for .NET 9 GA
f4c52d6 
There are very few changes as this point, but recording a new profile
shows a few changes, and maybe improvement by a very small amount:

    Before:
    Average(ms): 450.1
    Std Err(ms): 3.53537676760043
    Std Dev(ms): 11.1798429724611
    After:
    Average(ms): 448.6
    Std Err(ms): 2.54383787044519
    Std Dev(ms): 8.04432166879912

This is an average of 10 runs on a `dotnet new maui` template on a Pixel 7 Pro.

It might be effectively *the same*, but it's worth updating I suppose.
@jonathanpeppers jonathanpeppers requested a review from a team as a code owner October 24, 2024 16:49
@jonathanpeppers jonathanpeppers requested review from jfversluis and removed request for a team October 24, 2024 16:50
jonathanpeppers
jonathanpeppers commented Oct 24, 2024
View reviewed changes
src/Controls/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/maui.aotprofile.txt
Comment on lines -4868 to +4872
void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding1138676086 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, Microsoft.Maui.Controls.ImageSource>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object)
void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding114022620 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, string>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object)
void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding1635156915 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, Microsoft.Maui.Controls.ImageSource>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object)
void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding570983195 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, string>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object)
void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding1310226827 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, Microsoft.Maui.Controls.ImageSource>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object)
void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding1361557553 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, string>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object)
void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding1463606174 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, Microsoft.Maui.Controls.ImageSource>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object)
void Microsoft.Maui.Controls.Generated.GeneratedBindingInterceptors:SetBinding57528121 (Microsoft.Maui.Controls.BindableObject,Microsoft.Maui.Controls.BindableProperty,System.Func`2<Microsoft.Maui.Controls.BaseShellItem, string>,Microsoft.Maui.Controls.BindingMode,Microsoft.Maui.Controls.IValueConverter,object,string,object,object,object)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, @simonrozsival @jkurdek are the names like SetBinding1310226827 deterministic? Is it a hash of some kind?

Copy link
Member

@jkurdek jkurdek Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a hash of the location

maui/src/Controls/src/BindingSourceGen/BindingSourceGenerator.cs

Lines 42 to 49 in d541b54

context.RegisterImplementationSourceOutput(bindings, (spc, binding) =>
{
var fileName = $"{binding.Location.FilePath}-GeneratedBindingInterceptors-{binding.Location.Line}-{binding.Location.Column}.g.cs";
var sanitizedFileName = fileName.Replace('/', '-').Replace('\\', '-').Replace(':', '-');
var code = BindingCodeWriter.GenerateBinding(binding, (uint)Math.Abs(binding.Location.GetHashCode()));
spc.AddSource(sanitizedFileName, code);
});
}

@jonathanpeppers jonathanpeppers enabled auto-merge (squash) October 24, 2024 17:40
@PureWeen PureWeen added this to the .NET 9.0 GA milestone Oct 24, 2024
@rmarinho rmarinho disabled auto-merge October 25, 2024 01:40
@rmarinho rmarinho merged commit 4bb47d4 into release/9.0.1xx Oct 25, 2024
6 of 7 checks passed
@rmarinho rmarinho deleted the dev/peppers/net9/ga/aotprofile branch October 25, 2024 01:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@samhouts samhouts added fixed-in-9.0.0 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkurdek jkurdek jkurdek left review comments

@rmarinho rmarinho rmarinho approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
fixed-in-9.0.0 fixed-in-net8.0-nightly This may be available in a nightly release!
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 9.0 GA
Development

Successfully merging this pull request may close these issues.
5 participants
@jonathanpeppers @rmarinho @jkurdek @PureWeen @samhouts