[release/9.0.1xx] [Blazor Hybrid] Fire and forget BlazorWebView disposal by default
#25430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
commented
Oct 21, 2024
Comment on lines
+79
to
+81
| var shouldBlockOnDispose = AppContext.TryGetSwitch(AndroidFireAndForgetAsyncSwitch, out var enableFireAndForget) | ||
| ? !enableFireAndForget | ||
| : IsBlockingDisposalEnabled; |
There was a problem hiding this comment.
This logic ensures that if the "BlazorWebView.AndroidFireAndForgetAsync" switch was specified previously, we will continue to use that value, regardless of whether the new AppContext switch is also specified.
| else | ||
| { | ||
| // Otherwise, by default, we'll fire-and-forget the disposal task. | ||
| disposalTask.FireAndForget(); |
There was a problem hiding this comment.
Unlike with the other BlazorWebViewHandler implementations, there wasn't already an ILogger available to pass to the FireAndForget call here. If others think it's worth it or necessary to obtain one from the service provider, I won't object to adding it.
Eilon
approved these changes
Oct 21, 2024
samhouts
added
fixed-in-9.0.0
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default behavior of
BlazorWebViewHandlerto fire-and-forget the disposal of the underlyingWebViewManagerby default.Fixes #24407
Fixes #24250